Skip to content

Conversation

apoelstra
Copy link
Member

Automated update to Github CI workflow rust.yml by create-pull-request GitHub action

@apoelstra apoelstra force-pushed the create-pull-request/weekly-nightly-update branch from e7823b3 to 04c57e0 Compare September 20, 2025 01:52
@apoelstra apoelstra changed the title Automated update to nightly-version (to nightly-2025-09-12) Automated update to nightly-version (to nightly-2025-09-19) Sep 20, 2025
@apoelstra apoelstra force-pushed the create-pull-request/weekly-nightly-update branch from 04c57e0 to 60ba4cf Compare September 27, 2025 01:52
@apoelstra apoelstra changed the title Automated update to nightly-version (to nightly-2025-09-19) Automated update to nightly-version (to nightly-2025-09-26) Sep 27, 2025
@tcharding
Copy link
Member

Strange CI failures, if I had perms I would have just re-run the failed jobs.

@apoelstra
Copy link
Member Author

I reran it. Some result. Let's wait for next week and see if it persists. Weird that the same PR rust-bitcoin/rust-bitcoin#5041 on rust-bitcoin succeeded. Are we invoking clippy differently?

@tcharding
Copy link
Member

tcharding commented Sep 28, 2025

EDIT: derp this is bech32 not miniscript ...

(I just deleted the post because it was not useful).

We are running CI here the old fashioned way with a test.sh file, and clippy is being run with a stable toolchain instead of nightly. I didn't bother investigating more, should we just update CI to use run_task.

cc @clarkmoody are you down with that? Its a script we wrote to run CI in a bunch of other crates, its hosted here: https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools

(Not saying I can prioritise this right now though.)

@clarkmoody
Copy link
Member

We are running CI here the old fashioned way with a test.sh file, and clippy is being run with a stable toolchain instead of nightly. I didn't bother investigating more, should we just update CI to use run_task.

cc @clarkmoody are you down with that? Its a script we wrote to run CI in a bunch of other crates, its hosted here: https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools

(Not saying I can prioritise this right now though.)

I'm fine running CI that's commonly used elsewhere. But also, if it ain't broke...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants